🐛 fix challenge offset constants #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes to gas cost
🧾 Summary (20% most significant diffs)
Full diff report 👇
|
The constant value used as an offset to retrieve the challenge from the webauthn response was only correct for payload of type `webauthn.get`. This commit makes the offset value dynamic to also handle `webauthn.create` payloads. Both payloads are now correctly supported.
qd-qd
force-pushed
the
fix/webauthn-challenge-offset
branch
from
aa67e99 to
faf33fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constant value used as an offset to retrieve the
challenge from the webauthn response was only correct
for payload of type
webauthn.get. This commit makesthe offset value dynamic to also handle
webauthn.createpayloads. Both payloads are now correctly supported.