Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Implement Array.count() and Array.index() #20

Merged
merged 4 commits into from
Jul 28, 2020
Merged

ENH: Implement Array.count() and Array.index() #20

merged 4 commits into from
Jul 28, 2020

Conversation

gerrymanoim
Copy link
Owner

@gerrymanoim gerrymanoim commented Jul 21, 2020 •
edited
Loading

Also updated tests.

@gerrymanoim gerrymanoim marked this pull request as draft July 21, 2020 20:27
@github-actions github-actions bot added the enhancement New feature or request label Jul 21, 2020
@gerrymanoim gerrymanoim changed the title ENH: Implement Array.count() ENH: Implement Array.count() and Array.index() Jul 22, 2020
@gerrymanoim
Copy link
Owner Author

@llllllllll Not sure how I feel about the amount of code duplication between count and index. Will revisit again in the morning to see if I can clean that up.

@gerrymanoim gerrymanoim marked this pull request as ready for review July 22, 2020 05:43
@gerrymanoim gerrymanoim mentioned this pull request Jul 23, 2020
Merged
@gerrymanoim gerrymanoim merged commit 1ff2d7d into master Jul 28, 2020
@gerrymanoim gerrymanoim deleted the count branch July 28, 2020 01:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gerrymanoim