Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error in log - getVolumeInformation #22

Closed
RogerSelwyn opened this issue Mar 6, 2022 · 1 comment
Closed

Error in log - getVolumeInformation #22

RogerSelwyn opened this issue Mar 6, 2022 · 1 comment

Comments

@RogerSelwyn
Copy link
Contributor

I've had the following errors in my log, I think twice. I suspect it is because of a race condition between checking for whether the TV is switched on or not, and then checking for volume information. I noticed that the TV had just been switched off, when the errors were logged.

I haven't looked into the code, but I'm happy to try and debug and create a PR. I suspect that it isn't easily replicable, but I'd be pretty sure I can fake the situation so I can trigger the error, so it can be handle better. My suggestion would be to ignore the error (since as the message says, it is an error because the TV is switched off), or at worst put out a single warning message, rather than two errors.

2022-03-06 08:01:20 ERROR (SyncWorker_1) [braviapsk.sony_bravia_psk] Invalid response: {'error': [40005, 'Display Is Turned off'], 'id': 1}
request path: sony/audio
request params: {"method": "getVolumeInformation", "params": [], "id": 1, "version": "1.0"}
2022-03-06 08:01:20 ERROR (SyncWorker_1) [braviapsk.sony_bravia_psk] JSON request error:{
"error": [
40005,
"Display Is Turned off"
],
"id": 1
}
gerard33 pushed a commit that referenced this issue Mar 12, 2022
@gerard33
Copy link
Owner

Fixed in #23.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants