Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional Icons and Labels based on Protocol #6101

Conversation

MichelGabriel
Copy link
Contributor

This PR adds additional Icons and Labels in the detail (metadata record) view that are based on Protocol. Before icons and labels where only shown for a main type (WMS, WFS, etc) and all the others got a question mark.

Further changes:

  • labels on more than 1 line
  • WFS download option now in the right columns (in stead of middle column)

Screenshot after the changes

gn-additional-icons

Further changes:
- labels on more than 1 line
- WFS download option now in the right columns (in stead of middle column)
@josegar74 josegar74 added this to the 4.0.6 milestone Jan 11, 2022
Copy link
Member

@josegar74 josegar74 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine, a question about the colors. Some icons are displayed in green and others in gray, what is the criteria used for this?

@MichelGabriel
Copy link
Contributor Author

I'm not really sure, I left this as-is

@fxprunayre
Copy link
Member

Some icons are displayed in green and others in gray, what is the criteria used for this?

From #5465, an idea was to have some kind of color code for easy distinction of dataset / service - and maybe some EEA ongoing work will improve that, so that it applies more globally and also on series / applications ...

@jahow jahow modified the milestones: 4.0.6, 4.0.7 Feb 2, 2022
@fxprunayre fxprunayre modified the milestones: 4.2.0, 4.2.1 May 19, 2022
fxprunayre added a commit that referenced this pull request Jun 20, 2022
Follow up of #6371

* Cleanup styles to have same rendering of links in record view and editor (labels, icons) - Replace #6101
* Improve format encoding can use WWW:DOWNLOAD:{format} or a MimeFileType element in ISO standards.
* Create directive for uploading file that can be used in various places (eg. metadata filestore or form file or thumbnail upload)
* Upload file / Add file format to import eg. images only for thumbnails
fxprunayre added a commit that referenced this pull request Jul 6, 2022
…abels (#6411)

* Online source / Improve format support

Follow up of #6371

* Cleanup styles to have same rendering of links in record view and editor (labels, icons) - Replace #6101
* Improve format encoding can use WWW:DOWNLOAD:{format} or a MimeFileType element in ISO standards.
* Create directive for uploading file that can be used in various places (eg. metadata filestore or form file or thumbnail upload)
* Upload file / Add file format to import eg. images only for thumbnails

* Online source / Improve format support / Wro4j errors.

* Online source / Improve format support / Styling.
@fxprunayre
Copy link
Member

Replaced by #6411

@fxprunayre fxprunayre closed this Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants