Geotools v21.4 upgrade

[juanluisrp]

This pull request supersedes #3881 including its changes.

• Update JTS to v16. Old dependency was com.vividsolutions:jts:1.13. New version is org.locationtech.jts:jts-core:1.16.0 (see work done in Updated geotools dependencies #3198).
• Replaced imports listed in Geotools document https://docs.google.com/spreadsheets/d/1oE6mU4jp-ZL5PebgXf-fuhtf7MY5dzSwPqpMtrzdZ94/edit#gid=2055024842
• Add a new dependency on org.geotools.xsd:gt-xsd-fes.
• Replace removed org.geotools:gt-api dependency by org.geotools:gt-main.
• Replace dependency org.geotools:gt-wfs by org.geotools:gt-wfs-ng
• Replace all uses of com.vividsolutions.jts.util.Assert by org.springframework.util.Assert

[juanluisrp]

It seems there are some problems related with Mapfish print library that still depens on gt-render v 8.6:

Caused by: java.lang.VerifyError: Bad type on operand stack
Exception Details:
  Location:
    org/fao/geonet/services/region/ThesaurusBasedRegionsDAO.getGeom(Ljeeves/server/context/ServiceContext;Ljava/lang/String;ZLorg/opengis/referencing/crs/CoordinateReferenceSystem;)Lorg/locationtech/jts/geom/Geometry; @32: invokevirtual
  Reason:
    Type 'org/geotools/geometry/jts/ReferencedEnvelope' (current frame, stack[1]) is not assignable to 'org/locationtech/jts/geom/Envelope'
  Current Frame:
    bci: @32
    flags: { }
    locals: { 'org/fao/geonet/services/region/ThesaurusBasedRegionsDAO', 'jeeves/server/context/ServiceContext', 'java/lang/String', integer, 'org/opengis/referencing/crs/CoordinateReferenceSystem', 'org/fao/geonet/kernel/region/Region' }
    stack: { 'org/locationtech/jts/geom/GeometryFactory', 'org/geotools/geometry/jts/ReferencedEnvelope' }
  Bytecode:
    0x0000000: 2a2b b600 202c b600 21b6 0022 3a05 1905
    0x0000010: c700 0501 b02a b400 0919 0519 04b6 0023
    0x0000020: b600 243a 0619 0619 05b6 0025 b600 26b6
    0x0000030: 0027 1906 b0
  Stackmap Table:
    append_frame(@21,Object[#120])

The method causing launching the error is

core-geonetwork/services/src/main/java/org/fao/geonet/services/region/ThesaurusBasedRegionsDAO.java

Lines 102 to 113 in 78f197e

	@Override
	public Geometry getGeom(ServiceContext context, String id, boolean simplified, CoordinateReferenceSystem projection) throws Exception {
	Region region = createSearchRequest(context).id(id).get();
	if (region == null) {
	return null;
	}
	Geometry geometry = factory.toGeometry(region.getBBox(projection));
	geometry.setUserData(region.getBBox().getCoordinateReferenceSystem());
	return geometry;
	}

Analyzing the dependencies we can find org.geotools:gt-render:8.6 in the mapfish print-lib dependency tree

[fxprunayre]

Testing with @juanluisrp it looks like we have a wrong x/y order during WFS harvesting. Needs more test (tested with https://demo.geo-solutions.it/geoserver/web/).

[fxprunayre]

@juanluisrp, I tested quite some of the examples from https://docs.geotools.org/latest/userguide/library/referencing/order.html with no luck. If you can have a look that would be great.

[jodygarnett]

Update, I have been performing some tests against gt-wfs-ng and geoserver 2.15.2, see the resulting table here geotools/geotools#2492

TLDR:

• gt-wfs-ng does a better job of respecting what we ask for, previous implementation went to a lot of trouble to try and return in x/y order.
• even with the datastore respects what we ask for the service on the other end can be configured wrong or implemented poorly!
• general advise is to use WFS 1.1.0 and the "WFSDataStoreFactory:AXIS_ORDER" and "WFSDataStoreFactory:AXIS_ORDER_FILTER" connection parameters to account for differences between WFS implementations

[fxprunayre]

Replaced by #4488