Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing Default (TxBuilderStrategy m) constraint on GYTxBuilderMonad #325

Merged
merged 1 commit into from
Jul 25, 2024

Conversation

TotallyNotChase
Copy link
Contributor

Summary

Very small change. I removed this constraint in a previous commit as part of #322 thinking it's redundant. But that's not correct since most use cases don't care about choosing a strategy when building transactions. So most use sites will just require a verbose Default (TxBuilderStrategy m) constraint on top. This improves upon that.

Type of Change

Please mark the relevant option(s) for your pull request:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring (improving code quality without changing its behavior)
  • Documentation update (adding or updating documentation related to the project)

Checklist

Please ensure that your pull request meets the following criteria:

  • I have read the Contributing Guide
  • My code follows the project's coding style and best practices
  • My code is appropriately commented and includes relevant documentation
  • I have added tests to cover my changes
  • All new and existing tests pass
  • I have updated the documentation, if necessary

Testing

Additional Information

Copy link
Member

@sourabhxyz sourabhxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM!

@4TT1L4
Copy link
Contributor

4TT1L4 commented Jul 25, 2024

LGTM!

Thanks for the PR!

@4TT1L4 4TT1L4 merged commit 5f647ec into geniusyield:main Jul 25, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants