fix: correctly define screenshotsDir option for browsers #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DudaGod
commented
Feb 7, 2025
|
|
||
| if (!isSetByUser && fs.existsSync(deprecatedScreensPath) && !fs.existsSync(value)) { | ||
| return deprecatedScreensPath; | ||
| const topLevelScreenshotsDir = _.get(config, "screenshotsDir"); |
There was a problem hiding this comment.
for top level option this will be undefined because option is not set. But when parse browser this option will have value from top level. And will be used if user not set it specially for browser
sipayRT
approved these changes
Feb 7, 2025
KuznetsovRoman
approved these changes
Feb 7, 2025
DudaGod
force-pushed
the
TESTPLANE-447.fix_screenshotsDir
branch
from
5459724 to
c59bbb1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is done
The screenshotsDir field is not parsed correctly for browsers if the user uses the deprecated value (hermione/screens) and the field itself is specified at the top level (i.e. not inside any browser).