fix: remove unknown capabilities when running local browser #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KuznetsovRoman
force-pushed
the
TESTPLANE-384.local_remove_unknown_caps
branch
from
3cd7d66 to
2eb808c
Compare
KuznetsovRoman
commented
Dec 24, 2024
Comment on lines
+263
to
+274
| const filteredCapabilities: WebdriverIO.Capabilities = Object.keys(capabilities) | ||
| .filter(capabilityName => { | ||
| const isW3CCapability = W3C_CAPABILITIES.includes(capabilityName); | ||
| const isVendorSpecificCapability = VENDOR_CAPABILITIES[browserNameW3C].includes(capabilityName); | ||
|
|
||
| return isW3CCapability || isVendorSpecificCapability; | ||
| }) | ||
| .reduce((acc, capabilityName) => { | ||
| return set(acc, [capabilityName], capabilities[capabilityName as keyof WebdriverIO.Capabilities]); | ||
| }, {}); | ||
|
|
||
| return filteredCapabilities; |
There was a problem hiding this comment.
Remove all capabilities, which are not "w3c capabilities" or "vendor specific capabilities", as local webdriver can't recognize those and fail to launch browser
KuznetsovRoman
force-pushed
the
TESTPLANE-384.local_remove_unknown_caps
branch
3 times, most recently
from
781ca7b to
6ab67ec
Compare
shadowusr
approved these changes
Dec 27, 2024
| return set(acc, [capabilityName], capabilities[capabilityName as keyof WebdriverIO.Capabilities]); | ||
| }, {}); | ||
|
|
||
| return filteredCapabilities; |
There was a problem hiding this comment.
I suggest to write a message if some capabilities were omitted, because I think we might stumble on this in the future in circumstances we can't foresee now. Something like "Dropping non-standard capabilities due to running in local mode". Perhaps this should be in debug logs.
KuznetsovRoman
force-pushed
the
TESTPLANE-384.local_remove_unknown_caps
branch
from
6ab67ec to
6e75965
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.