USD to SDF: some fixes #991
Conversation
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
| @@ -302,6 +303,8 @@ namespace usd | |||
| } | |||
| sdf::usd::ParseUSDLinks( | |||
| prim, linkName, optionalLink, usdData, scale->second); | |||
| *linkInserted = optionalLink.value(); | |||
| linkScaleMap[linkName] = scale->second; | |||
There was a problem hiding this comment.
I'm not sure that this line is needed. A few lines above, we get the iterator to the pairing of the link name and scale, and then when sdf::usd::ParseUSDLinks is called before this assignment, the scale is passed as a mutable reference. So, I believe the assignment being done here (i.e., updating the link's scale) should be done automatically since we are using iterators and references. Do things still work if this line is removed?
Signed-off-by: ahcorde <ahcorde@gmail.com>
Signed-off-by: ahcorde <ahcorde@gmail.com>
…nrobotics/sdformat into ahcorde/usd_to_sdf/fixes
Codecov Report
@@ Coverage Diff @@
## sdf12 #991 +/- ##
=======================================
Coverage 65.38% 65.38%
=======================================
Files 2 2
Lines 26 26
=======================================
Hits 17 17
Misses 9 9 Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <ahcorde@gmail.com>
|
@osrf-jenkins retest this please |
* USD to SDF: Added Lights attached to models (#903) Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com> * USD to SDF: Added diff drive plugin (#904) Signed-off-by: ahcorde <ahcorde@gmail.com> Co-authored-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com> * USD to SDF: some fixes (#991) Signed-off-by: ahcorde <ahcorde@gmail.com> * Added equality operators to Plugin (#912) * Added convenience constructor to plugin Signed-off-by: Nate Koenig <nate@openrobotics.org> * Added equality operators to Plugin Signed-off-by: Nate Koenig <nate@openrobotics.org> * Remove common dependency Signed-off-by: Nate Koenig <nate@openrobotics.org> * Fixed test Signed-off-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Nate Koenig <nate@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Louise Poubel <louise@openrobotics.org> Co-authored-by: Alejandro Hernández Cordero <ahcorde@gmail.com> Co-authored-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com> Co-authored-by: Nate Koenig <nkoenig@users.noreply.github.com> Co-authored-by: Nate Koenig <nate@openrobotics.org>
Signed-off-by: ahcorde ahcorde@gmail.com
🦟 Bug fix
Summary
Fixed
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.