Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sdf -> usd Parse links and ground planes #828

Merged
merged 10 commits into from
Feb 18, 2022
Merged

Conversation

ahcorde
Copy link
Collaborator

@ahcorde ahcorde commented Jan 25, 2022

Signed-off-by: ahcorde ahcorde@gmail.com

🦟 Bug fix

Summary

This PR parse SDF up to links and convert it to USD

  • Links include inertial
  • Added tests for lights inside links

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: ahcorde <ahcorde@gmail.com>
@ahcorde ahcorde requested a review from adlarkin January 25, 2022 17:23
@ahcorde ahcorde requested a review from azeey as a code owner January 25, 2022 17:23
@ahcorde ahcorde self-assigned this Jan 25, 2022
@ahcorde ahcorde requested a review from scpeters as a code owner January 25, 2022 17:23
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 25, 2022
@codecov-commenter
Copy link

codecov-commenter commented Jan 25, 2022

Codecov Report

Merging #828 (f816dd4) into sdf12 (8e89865) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##            sdf12     #828   +/-   ##
=======================================
  Coverage   90.80%   90.80%           
=======================================
  Files          78       78           
  Lines       12555    12555           
=======================================
  Hits        11400    11400           
  Misses       1155     1155           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9272cb6...f816dd4. Read the comment docs.

@ahcorde ahcorde requested a review from koonpeng January 26, 2022 08:23
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@adlarkin adlarkin changed the title sdf -> usd Parse links sdf -> usd Parse links and ground planes Jan 27, 2022
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but we should probably wait to merge this until the other PRs that depend on it (for example, joints) are created. I say this because we are introducing a new API for parsing a model, and once we merge this, we cannot update the model API since that would break API. So, let's make sure that the APIs proposed here don't cause issues with other parts of model parsing before doing any merging.

@adlarkin adlarkin mentioned this pull request Jan 27, 2022
8 tasks
@ahcorde ahcorde requested a review from adlarkin February 14, 2022 17:53
…rapped sdf errors

Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Copy link
Contributor

@adlarkin adlarkin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I am going to review the other PRs that require this one (#829, #830, #831) before giving this PR official approval to make sure that we don't need to modify the public API introduced in this PR for any of the other dependent PRs.

Also, it would be nice if we can get #850 reviewed and merged before merging this PR, because if we do decide to merge #850, then a few internal API calls made in this PR will need to be updated.

@adlarkin
Copy link
Contributor

Also, it would be nice if we can get #850 reviewed and merged before merging this PR, because if we do decide to merge #850, then a few internal API calls made in this PR will need to be updated.

I have merged in #850 and resolved conflicts in f816dd4. I will now work on getting #829, #830, and #831 updated/reviewed.

@ahcorde
Copy link
Collaborator Author

ahcorde commented Feb 16, 2022

@adlarkin CI is working again

Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
Signed-off-by: Ashton Larkin <42042756+adlarkin@users.noreply.github.com>
@adlarkin adlarkin requested a review from scpeters February 18, 2022 02:33
@ahcorde ahcorde merged commit 5059bb8 into sdf12 Feb 18, 2022
@ahcorde ahcorde deleted the ahcorde/sdf_to_usd_links branch February 18, 2022 16:34
@scpeters scpeters mentioned this pull request Feb 24, 2022
8 tasks
@ahcorde ahcorde mentioned this pull request Mar 4, 2022
8 tasks
@adlarkin adlarkin mentioned this pull request Apr 1, 2022
8 tasks
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-04-13-fortress-edifice/1367/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants