Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make zmq check for post 4.3.1 not to include 4.3.1 #237

Merged
merged 2 commits into from
May 6, 2021

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Apr 5, 2021

🦟 Bug fix

Summary

When building Debian packages for Debian/Buster I needed to use this patch to fix compilation. Seems like we were including the 4.3.1 to define the IGN_ZMQ_POST_4_3_1 variable, which clearly seems to be a mistake.

Checklist

  • Signed all commits for DCO

Note to maintainers: Remember to use Squash-Merge

Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
@j-rivero j-rivero requested a review from caguero as a code owner April 5, 2021 16:49
@github-actions github-actions bot added 🏢 edifice Ignition Edifice 🏯 fortress Ignition Fortress labels Apr 5, 2021
@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #237 (e993d68) into ign-transport10 (222d4d6) will not change coverage.
The diff coverage is n/a.

❗ Current head e993d68 differs from pull request most recent head bcf8485. Consider uploading reports for the commit bcf8485 to get more accurate results
Impacted file tree graph

@@               Coverage Diff                @@
##           ign-transport10     #237   +/-   ##
================================================
  Coverage            89.07%   89.07%           
================================================
  Files                   49       49           
  Lines                 4678     4678           
================================================
  Hits                  4167     4167           
  Misses                 511      511           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 699e712...bcf8485. Read the comment docs.

@caguero
Copy link
Collaborator

caguero commented Apr 5, 2021

CC @mjcarroll . I remember he created a PR to fix a problem in Debian because the version of the code they had didn't make a lot of sense. Just double checking...

@caguero caguero requested a review from mjcarroll April 9, 2021 20:11
@chapulina chapulina removed the 🏯 fortress Ignition Fortress label Apr 19, 2021
@mjcarroll
Copy link
Contributor

Here was the original context: #157 and the original fix: #159

@chapulina
Copy link
Contributor

Thanks for the context, @mjcarroll . The original issue was failing the Focal build, but this PR passes on Focal. So I think there's no regression here.

@chapulina chapulina enabled auto-merge (squash) May 5, 2021 23:43
@chapulina chapulina merged commit 3ae2925 into ign-transport10 May 6, 2021
@chapulina chapulina deleted the jrivero/fix_post_4_3_1_check branch May 6, 2021 00:04
scpeters added a commit to gazebo-release/ign-transport10-release that referenced this pull request Oct 27, 2021
Patch merged in gazebosim/gz-transport#237

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
scpeters pushed a commit to scpeters/ign-transport that referenced this pull request Oct 27, 2021
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
scpeters pushed a commit that referenced this pull request Oct 27, 2021
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
scpeters added a commit to gazebo-release/ign-transport10-release that referenced this pull request Oct 27, 2021
Patch merged in gazebosim/gz-transport#237

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1

@osrf-triage
Copy link

This pull request has been mentioned on Gazebo Community. There might be relevant details there:

https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏢 edifice Ignition Edifice
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants