-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make zmq check for post 4.3.1 not to include 4.3.1 #237
Conversation
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org>
Codecov Report
@@ Coverage Diff @@
## ign-transport10 #237 +/- ##
================================================
Coverage 89.07% 89.07%
================================================
Files 49 49
Lines 4678 4678
================================================
Hits 4167 4167
Misses 511 511 Continue to review full report at Codecov.
|
CC @mjcarroll . I remember he created a PR to fix a problem in Debian because the version of the code they had didn't make a lot of sense. Just double checking... |
Thanks for the context, @mjcarroll . The original issue was failing the Focal build, but this PR passes on Focal. So I think there's no regression here. |
Patch merged in gazebosim/gz-transport#237 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Jose Luis Rivero <jrivero@osrfoundation.org> Co-authored-by: Louise Poubel <louise@openrobotics.org>
Patch merged in gazebosim/gz-transport#237 Signed-off-by: Steve Peters <scpeters@openrobotics.org>
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-01-10/1228/1 |
This pull request has been mentioned on Gazebo Community. There might be relevant details there: https://community.gazebosim.org/t/new-ignition-releases-2022-03-25-fortress-edifice-citadel/1343/1 |
🦟 Bug fix
Summary
When building Debian packages for Debian/Buster I needed to use this patch to fix compilation. Seems like we were including the
4.3.1
to define theIGN_ZMQ_POST_4_3_1
variable, which clearly seems to be a mistake.Checklist
Note to maintainers: Remember to use Squash-Merge