Fix custom sensor system example build #2649
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ian Chen <ichen@openrobotics.org>
8 tasks
ahcorde
approved these changes
Oct 11, 2024
This was referenced Oct 15, 2024
arjo129
added a commit
that referenced
this pull request
Nov 18, 2024
…ary. (#2596) * A hack to greatly improve load times I was investigating gazebosim/gazebo_test_cases#1576 , in my investigation it came to my notice that `sdf::Element` takes forever to destroy (We should open a ticket somewhere about this). If we are skipping serialization we might as well not create and destroy an SDF Element. This hack greatly speeds up the load time for gazebo. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Remove magic word Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Send empty string instead of using sentinel value. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Style Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * fix custom sensor system example build (#2649) Signed-off-by: Ian Chen <ichen@openrobotics.org> * remove stray change Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> --------- Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Signed-off-by: Ian Chen <ichen@openrobotics.org> Co-authored-by: Ian Chen <ichen@openrobotics.org>
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
…ary. (#2596) * A hack to greatly improve load times I was investigating gazebosim/gazebo_test_cases#1576 , in my investigation it came to my notice that `sdf::Element` takes forever to destroy (We should open a ticket somewhere about this). If we are skipping serialization we might as well not create and destroy an SDF Element. This hack greatly speeds up the load time for gazebo. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Remove magic word Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Send empty string instead of using sentinel value. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Style Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * fix custom sensor system example build (#2649) Signed-off-by: Ian Chen <ichen@openrobotics.org> * remove stray change Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> --------- Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Signed-off-by: Ian Chen <ichen@openrobotics.org> Co-authored-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 1a88131)
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
…ary. (#2596) * A hack to greatly improve load times I was investigating gazebosim/gazebo_test_cases#1576 , in my investigation it came to my notice that `sdf::Element` takes forever to destroy (We should open a ticket somewhere about this). If we are skipping serialization we might as well not create and destroy an SDF Element. This hack greatly speeds up the load time for gazebo. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Remove magic word Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Send empty string instead of using sentinel value. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Style Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * fix custom sensor system example build (#2649) Signed-off-by: Ian Chen <ichen@openrobotics.org> * remove stray change Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> --------- Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Signed-off-by: Ian Chen <ichen@openrobotics.org> Co-authored-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 1a88131)
mergify bot
pushed a commit
that referenced
this pull request
Nov 19, 2024
…ary. (#2596) * A hack to greatly improve load times I was investigating gazebosim/gazebo_test_cases#1576 , in my investigation it came to my notice that `sdf::Element` takes forever to destroy (We should open a ticket somewhere about this). If we are skipping serialization we might as well not create and destroy an SDF Element. This hack greatly speeds up the load time for gazebo. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Remove magic word Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Send empty string instead of using sentinel value. Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * Style Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> * fix custom sensor system example build (#2649) Signed-off-by: Ian Chen <ichen@openrobotics.org> * remove stray change Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> --------- Signed-off-by: Arjo Chakravarty <arjoc@intrinsic.ai> Signed-off-by: Ian Chen <ichen@openrobotics.org> Co-authored-by: Ian Chen <ichen@openrobotics.org> (cherry picked from commit 1a88131) # Conflicts: # include/gz/sim/components/Model.hh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
The Plugins/ExamplesBuild test started failing since we bumped the version in gz-sensors's
mainbranch. This PR updates the custom sensor example's CMakeLists to checkoutgz-sensors9instead ofmainChecklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-bymessages.