Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bumps in garden : ci_matching_branch/bump_garden_ign-gazebo7 #1234

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

scpeters
Copy link
Member

@scpeters scpeters commented Dec 5, 2021

Signed-off-by: Steve Peters <scpeters@openrobotics.org>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Dec 5, 2021
@scpeters
Copy link
Member Author

scpeters commented Dec 5, 2021

Needs gazebosim/gz-msgs#204 in order to pass

@codecov
Copy link

codecov bot commented Dec 6, 2021

Codecov Report

Merging #1234 (b291d11) into main (cddc011) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1234   +/-   ##
=======================================
  Coverage   61.87%   61.88%           
=======================================
  Files         274      274           
  Lines       22446    22446           
=======================================
+ Hits        13889    13891    +2     
+ Misses       8557     8555    -2     
Impacted Files Coverage Δ
src/EntityComponentManager.cc 87.15% <0.00%> (+0.12%) ⬆️
src/Server.cc 86.74% <0.00%> (+0.60%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cddc011...b291d11. Read the comment docs.

@scpeters
Copy link
Member Author

scpeters commented Dec 6, 2021

CI status:

  • lots of test failures on homebrew, but I think that's not unusual at the moment on these branches
  • windows build failed on windows_nuc, Unknown CMake command "PROTOBUF_GENERATE_CPP"

@chapulina
Copy link
Contributor

CI status:

That sounds fine to me. We should merge this as soon as possible because the current main branch is incompatible with some dependencies (ign-gui, ign-rendering, etc.)

@scpeters scpeters merged commit 080bde1 into main Dec 6, 2021
@scpeters scpeters deleted the ci_matching_branch/bump_garden_ign-gazebo7 branch December 6, 2021 17:44
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants