Merge ign-launch2 ➡️ ign-launch5 #214
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: methylDragon <methylDragon@gmail.com>
Signed-off-by: Nate Koenig <nate@openrobotics.org>
This reverts commit f1d1ae9.
* Small cleanup fixes Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Missing colon Signed-off-by: Nate Koenig <natekoenig@gmail.com> * Fix linting Signed-off-by: Steve Peters <scpeters@openrobotics.org> --------- Signed-off-by: Nate Koenig <natekoenig@gmail.com> Signed-off-by: Steve Peters <scpeters@openrobotics.org> Co-authored-by: Steve Peters <scpeters@openrobotics.org>
The LICENSE file contained a copy of the stanze used at the top of source code files, while the actual license was in the COPYING file. So remove the stanza and put the actual Apache 2.0 license text in LICENSE. Similar to gazebosim/gz-math#521. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Version v2 of the actions/checkout workflow is deprecated, so switch to v3. Part of gazebo-tooling/release-tools#862. Signed-off-by: Steve Peters <scpeters@openrobotics.org>
Codecov Report
@@ Coverage Diff @@
## ign-launch5 #214 +/- ##
============================================
Coverage 58.83% 58.83%
============================================
Files 3 3
Lines 396 396
============================================
Hits 233 233
Misses 163 163 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
iche033
approved these changes
Mar 27, 2023
There was a problem hiding this comment.
apart from the ABI breakage (as also mentioned in #211 (comment)), looks good to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
➡️ Forward port
Port
ign-launch2➡️ign-launch5Branch comparison: ign-launch5...ign-launch2
Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)