-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set per-point color on markers #318
Conversation
c40f51a
to
b7e3a24
Compare
Signed-off-by: Louise Poubel <louise@openrobotics.org>
652dc0b
to
26125a8
Compare
oh I think it just needs #321 to be ported forward |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me as expected.
Codecov Report
@@ Coverage Diff @@
## main #318 +/- ##
==========================================
- Coverage 65.74% 65.62% -0.12%
==========================================
Files 34 34
Lines 4752 4751 -1
==========================================
- Hits 3124 3118 -6
- Misses 1628 1633 +5
Continue to review full report at Codecov.
|
🎉 New feature
Part of
Requires
Builds on top of
Summary
If a message specifies multiple colors, use different colors for each point. Otherwise, fallback to current behaviour.
The branch is currently on
ign-gui6
while I work on the implementation, but the goal is to merge this intomain
after gazebo-tooling/release-tools#554.Test it
Run the
marker
example and see that both the single material and the per-point material work:Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge
🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸🔸