Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

3 ➡️ 4 #102

Merged
merged 4 commits into from
Aug 18, 2020
Merged

3 ➡️ 4 #102

merged 4 commits into from
Aug 18, 2020

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Aug 13, 2020

Once this is in, I'll work on a new ign-fuel-tools4 release, to help with gazebosim/gazebo-classic#2822

chapulina and others added 3 commits August 12, 2020 16:41
Signed-off-by: Louise Poubel <louise@openrobotics.org>
Adds support for downloading collections via ign fuel download. By default it downloads all items in a collection, but a -t option can be given to only download models or worlds in the collection. A -j option can be used to specify the number of parallel downloads.

Signed-off-by: Addisu Z. Taddese <addisu@openrobotics.org>

Co-authored-by: Louise Poubel <louise@openrobotics.org>
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from nkoenig as a code owner August 13, 2020 22:25
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 13, 2020
@codecov
Copy link

codecov bot commented Aug 13, 2020

Codecov Report

Merging #102 into ign-fuel-tools4 will increase coverage by 0.95%.
The diff coverage is 89.77%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##           ign-fuel-tools4     #102      +/-   ##
===================================================
+ Coverage            75.72%   76.68%   +0.95%     
===================================================
  Files                   16       18       +2     
  Lines                 2352     2526     +174     
===================================================
+ Hits                  1781     1937     +156     
- Misses                 571      589      +18     
Impacted Files Coverage Δ
src/FuelClient.cc 67.94% <84.09%> (+1.27%) ⬆️
src/ign.cc 62.00% <88.60%> (+6.11%) ⬆️
src/CollectionIdentifier.cc 96.15% <96.15%> (ø)
...nclude/ignition/fuel_tools/CollectionIdentifier.hh 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8f78efc...03530c8. Read the comment docs.

Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina
Copy link
Contributor Author

@osrf-jenkins run tests please

@chapulina chapulina self-assigned this Aug 17, 2020
@chapulina chapulina merged commit 8495f76 into ign-fuel-tools4 Aug 18, 2020
@chapulina chapulina deleted the chapulina/3_to_4 branch August 18, 2020 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants