Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Uses assimp for loading bvh animations #425

Closed
wants to merge 1 commit into from
Closed

Uses assimp for loading bvh animations #425

wants to merge 1 commit into from

Conversation

onurtore
Copy link
Contributor

Signed-off-by: Onur Berk Tore otore19@ku.edu.tr

🦟 Bug fix

Fixes #393

Summary

Uses assimp for loading bvh animations.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Uses assimp for loading bvh animations
a2b7973 
Signed-off-by: Onur Berk Tore <otore19@ku.edu.tr>
@onurtore onurtore mentioned this pull request Aug 17, 2022
Open
8 tasks
@luca-della-vedova
Copy link
Member

From what I understand for all loaders we introduced an environment variable to denote whether to use assimp or not, should we adopt the same approach here rather than always overriding the previous one?

@mjcarroll mjcarroll mentioned this pull request Sep 30, 2022
Closed
8 tasks
@azeey
Copy link
Contributor

azeey commented Nov 21, 2022

Can this be closed?

@azeey azeey requested a review from ahcorde November 21, 2022 19:27
@onurtore onurtore closed this Nov 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luca-della-vedova luca-della-vedova Awaiting requested review from luca-della-vedova

@ahcorde ahcorde Awaiting requested review from ahcorde

@marcoag marcoag Awaiting requested review from marcoag marcoag will be requested when the pull request is marked ready for review marcoag is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onurtore @luca-della-vedova @azeey