-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce example names to be able to run Conda CI on Windows (gz-cmake4) #476
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
9498b62
Reduce example names to be able to run Conda CI on Windows (gz-cmake2…
j-rivero 9287af6
Fixes after the initial merge
j-rivero a3d8291
Port test to gz
j-rivero e1493c1
Typo in variable name
j-rivero 50ff266
Do not use PREFIX_PATH and INSTALL_PREFIX for the same value
j-rivero dea99db
Merge branch 'gz-cmake4' into jrivero/port_463
j-rivero fa0ddc4
Remove no_ign_prefix example
j-rivero d5240a2
Fix bad merge
j-rivero dff7c93
One more fix to merge
scpeters 6e2d55b
fix whitespace and readmes
scpeters 85ce09d
revert changes to comp_deps[ABC] examples
scpeters b47a4a4
fix a readme
scpeters File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
examples/core_child/CMakeLists.txt → examples/c_child/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
cmake_minimum_required(VERSION 3.22.1 FATAL_ERROR) | ||
project(gz-core_child VERSION 0.1.0) | ||
project(gz-c_child VERSION 0.1.0) | ||
find_package(gz-cmake4 REQUIRED) | ||
gz_configure_project() | ||
gz_find_package(gz-core_no_deps REQUIRED EXTRA_ARGS NAMES gz-core_no_deps) | ||
gz_find_package(gz-c_no_deps REQUIRED EXTRA_ARGS NAMES gz-c_no_deps) | ||
gz_configure_build(QUIT_IF_BUILD_ERRORS) | ||
gz_create_packages() | ||
gz_create_docs(TAGFILES "${GZ-CORE_NO_DEPS_DOXYGEN_TAGFILE} = ${GZ-CORE_NO_DEPS_API_URL}") |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions
4
examples/core_child_private/CMakeLists.txt → examples/c_child_private/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
cmake_minimum_required(VERSION 3.22.1 FATAL_ERROR) | ||
project(gz-core_child_private VERSION 0.1.0) | ||
project(gz-c_child_private VERSION 0.1.0) | ||
find_package(gz-cmake4 REQUIRED) | ||
gz_configure_project() | ||
gz_find_package(gz-core_no_deps PRIVATE REQUIRED) | ||
gz_find_package(gz-c_no_deps PRIVATE REQUIRED) | ||
gz_configure_build(QUIT_IF_BUILD_ERRORS) | ||
gz_create_packages() | ||
gz_create_docs(TAGFILES "${GZ-CORE_NO_DEPS_DOXYGEN_TAGFILE} = ${GZ-CORE_NO_DEPS_API_URL}") |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions
4
examples/core_nodep/CMakeLists.txt → examples/c_nodep/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
...ples/core_nodep_static/src/CMakeLists.txt → examples/c_nodep/src/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,3 @@ | ||
gz_get_libsources_and_unittests(sources gtest_sources) | ||
gz_create_core_library(SOURCES ${sources} CXX_STANDARD 11) | ||
gz_build_tests(TYPE UNIT SOURCES ${gtest_sources}) | ||
gz_build_tests(TYPE UNIT SOURCES ${gtest_sources}) |
File renamed without changes.
4 changes: 2 additions & 2 deletions
4
examples/core_nodep_static/CMakeLists.txt → examples/c_nodep_static/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
examples/core_nodep_static/README.md → examples/c_nodep_static/README.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
4 changes: 2 additions & 2 deletions
4
examples/core_static_child/CMakeLists.txt → examples/c_static_child/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
cmake_minimum_required(VERSION 3.22.1 FATAL_ERROR) | ||
project(gz-core_static_child VERSION 0.1.0) | ||
project(gz-c_static_child VERSION 0.1.0) | ||
find_package(gz-cmake4 REQUIRED) | ||
gz_configure_project() | ||
gz_find_package(gz-core_no_deps_static REQUIRED) | ||
gz_find_package(gz-c_no_deps_static REQUIRED) | ||
gz_configure_build(QUIT_IF_BUILD_ERRORS) | ||
gz_create_packages() | ||
gz_create_docs(TAGFILES "${GZ-CORE_NO_DEPS_STATIC_DOXYGEN_TAGFILE} = ${GZ-CORE_NO_DEPS_STATIC_API_URL}") |
6 changes: 3 additions & 3 deletions
6
examples/core_static_child/README.md → examples/c_static_child/README.md
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# component\_deps | ||
# comp\_deps | ||
|
||
A package with two components (`child` and `parent`) with a dependency | ||
relationship between the components (`child` links against `parent`). |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 2 additions & 2 deletions
4
examples/use_component_depsC/CMakeLists.txt → examples/comp_depsA/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
cmake_minimum_required(VERSION 3.22.1 FATAL_ERROR) | ||
project(gz-use_component_depsC VERSION 0.1.0) | ||
project(gz-comp_depsA VERSION 0.1.0) | ||
find_package(gz-cmake4 REQUIRED) | ||
gz_configure_project() | ||
gz_find_package(gz-component_deps REQUIRED COMPONENTS child) | ||
gz_find_package(gz-comp_deps REQUIRED COMPONENTS parent child) | ||
gz_configure_build(QUIT_IF_BUILD_ERRORS) | ||
gz_create_packages() | ||
gz_create_docs() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# comp\_depsA | ||
|
||
This package uses the `child` and `parent` components of `comp_deps` | ||
and calls `gz_find_package` with the components specified | ||
in the order `parent child`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
4 changes: 2 additions & 2 deletions
4
examples/use_component_depsA/CMakeLists.txt → examples/comp_depsB/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
cmake_minimum_required(VERSION 3.22.1 FATAL_ERROR) | ||
project(gz-use_component_depsA VERSION 0.1.0) | ||
project(comp_depsB VERSION 0.1.0) | ||
find_package(gz-cmake4 REQUIRED) | ||
gz_configure_project() | ||
gz_find_package(gz-component_deps REQUIRED COMPONENTS parent child) | ||
gz_find_package(gz-comp_deps REQUIRED COMPONENTS child parent) | ||
gz_configure_build(QUIT_IF_BUILD_ERRORS) | ||
gz_create_packages() | ||
gz_create_docs() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
# comp\_depsB | ||
|
||
This package uses the `child` and `parent` components of `comp_deps` | ||
and calls `gz_find_package` with the components specified | ||
in the order `child parent`. | ||
Aside from the order in which the components are specified, | ||
this package is identical to `comp_depsA`. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
4 changes: 2 additions & 2 deletions
4
examples/use_component_depsB/CMakeLists.txt → examples/comp_depsC/CMakeLists.txt
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,8 +1,8 @@ | ||
cmake_minimum_required(VERSION 3.22.1 FATAL_ERROR) | ||
project(gz-use_component_depsB VERSION 0.1.0) | ||
project(comp_depsC VERSION 0.1.0) | ||
find_package(gz-cmake4 REQUIRED) | ||
gz_configure_project() | ||
gz_find_package(gz-component_deps REQUIRED COMPONENTS child parent) | ||
gz_find_package(gz-comp_deps REQUIRED COMPONENTS child) | ||
gz_configure_build(QUIT_IF_BUILD_ERRORS) | ||
gz_create_packages() | ||
gz_create_docs() |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,4 @@ | ||
# comp\_depsC | ||
|
||
This package uses the `child` component of `comp_deps` | ||
but should also find the `parent` component indirectly. |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
gz_get_libsources_and_unittests(sources gtest_sources) | ||
gz_create_core_library(SOURCES ${sources} CXX_STANDARD 11) | ||
target_link_libraries(${PROJECT_LIBRARY_TARGET_NAME} | ||
PUBLIC | ||
gz-comp_deps::gz-comp_deps-child) | ||
gz_build_tests(TYPE UNIT SOURCES ${gtest_sources}) |
File renamed without changes.
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
set(CONFIG_TEST "The package was found using MODULE mode") |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
set(CONFIG_TEST "The package was found using CONFIG mode") |
File renamed without changes.
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some of these files are mixed up; this is
_depsC
->_depsA
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some changes in 85ce09d which I believe are correct but the git diff is still confused