Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

⬆️ 2.5.0 #113

Merged
merged 1 commit into from
Sep 8, 2020
Merged

⬆️ 2.5.0 #113

merged 1 commit into from
Sep 8, 2020

Conversation

chapulina
Copy link
Contributor

Prepare for 2.5.0 release.

I thought we wouldn't need a release just for #111 because it only affects documentation. But it is causing warnings on our CI, so I think a quick release is in order.

CMake Warning (dev) at /usr/share/cmake/ignition-cmake2/cmake2/IgnUtils.cmake:1758 (message):
  

  The build script has specified some unrecognized arguments for
  ign_create_docs(~):

  
  ADDITIONAL_INPUT_DIRS;/var/lib/jenkins/workspace/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/ign-gazebo/src/systems
  /var/lib/jenkins/workspace/ignition_gazebo-ci-pr_any-ubuntu_auto-amd64/ign-gazebo/src/gui/plugins


  Either the script has a typo, or it is using an unexpected version of
  ign-cmake.  The version of ign-cmake currently being used is 2.4.0

Call Stack (most recent call first):
  /usr/share/cmake/ignition-cmake2/cmake2/IgnCreateDocs.cmake:50 (_ign_cmake_parse_arguments)
  CMakeLists.txt:164 (ign_create_docs)
This warning is for project developers.  Use -Wno-dev to suppress it.

@chapulina
⬆️ 2.5.0
0508f94 
Signed-off-by: Louise Poubel <louise@openrobotics.org>
@chapulina chapulina requested a review from mxgrey as a code owner September 5, 2020 16:08
@github-actions github-actions bot added 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Sep 5, 2020
@chapulina chapulina added the beta Targeting beta release of upcoming collection label Sep 8, 2020
scpeters
scpeters approved these changes Sep 8, 2020
View reviewed changes
Changelog.md
@@ -2,6 +2,11 @@

### Ignition CMake 2.X.X (20XX-XX-XX)

### Ignition CMake 2.5.0 (2020-09-05)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry reviews were too late for this date to be correct

@chapulina chapulina merged commit eac0b65 into ign-cmake2 Sep 8, 2020
@chapulina chapulina deleted the chapulina/2.5.0 branch September 8, 2020 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scpeters scpeters scpeters approved these changes

@mxgrey mxgrey Awaiting requested review from mxgrey

Assignees
No one assigned
Labels
beta Targeting beta release of upcoming collection 📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chapulina @scpeters