www(fix): update line height for newlines in code blocks #21711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…for better readability
fk
approved these changes
Feb 25, 2020
|
I don't remember when this was last working, it's been like this for a while 😬 |
|
FYI: #18719 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds some styles to how Prism renders empty lines so that our code blocks are more readable.
Here's how it looks on the left, compared to what .org shows on the right:
The code blocks in the docs have newlines so clicking the copy button accurately copies the code with line breaks preserved, but when rendered there is an element created by Prism with no content inside. By giving it a minimum height and updating it's display property it pushes the content below it down to display like the code is represented in reality.
Related Issues
None (that I know of), noticed this problem a while ago