Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add expectedFileOwner option to pod-files rule #52

Merged
merged 2 commits into from
Oct 16, 2023
Merged

Add expectedFileOwner option to pod-files rule #52

merged 2 commits into from
Oct 16, 2023

Conversation

AleksandarSavchev
Copy link
Member

@AleksandarSavchev AleksandarSavchev commented Oct 12, 2023 •
edited
Loading

What this PR does / why we need it:
This PR adds a new option expectedFileOwner to DISA Kubernetes STIGS pod-files rule which allows the user to select which users and groups are expected in the config file. The options defaults to expecting only ID 0 for users and groups

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Added new option `expectedFileOwner` to DISA Kubernetes STIGS `pod-files` rule which allows the user to select which `users `and `groups` are expected. The options defaults to expecting only ID `0` for `users` and `groups`.

@AleksandarSavchev AleksandarSavchev requested a review from a team as a code owner October 12, 2023 14:56
@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Oct 12, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 12, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 12, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Oct 13, 2023
dimityrmirchev
dimityrmirchev approved these changes Oct 16, 2023
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Oct 16, 2023
@dimityrmirchev dimityrmirchev merged commit 8e49715 into gardener:main Oct 16, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Oct 16, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Oct 16, 2023
@AleksandarSavchev AleksandarSavchev deleted the add-pod-files-options branch February 7, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimityrmirchev dimityrmirchev dimityrmirchev approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AleksandarSavchev @dimityrmirchev @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot