[Security Hardened Shoot Cluster] Rule 2003 implementation #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
gardener-robot
added
the
size/m
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
added
needs/ok-to-test
gardener-robot-ci-3
added
reviewed/ok-to-test
AleksandarSavchev
requested changes
Nov 5, 2024
| @@ -0,0 +1,182 @@ | |||
| // SPDX-FileCopyrightText: 2023 SAP SE or an SAP affiliate company and Gardener contributors | |||
There was a problem hiding this comment.
Suggested change
| // SPDX-FileCopyrightText: 2023 SAP SE or an SAP affiliate company and Gardener contributors | |
| // SPDX-FileCopyrightText: 2024 SAP SE or an SAP affiliate company and Gardener contributors |
| func() {}, | ||
| rule.RuleResult{RuleID: ruleID, RuleName: ruleName, CheckResults: []rule.CheckResult{{Status: rule.Passed, Message: "Default kubelet config does not disable kernel protection.", Target: rule.NewTarget()}}}, | ||
| ), | ||
| Entry("should pass when shoot does sets default kubelet config", |
There was a problem hiding this comment.
Suggested change
| Entry("should pass when shoot does sets default kubelet config", | |
| Entry("should pass when shoot sets default kubelet config", |
| {Status: rule.Passed, Message: "Worker kubelet config enables kernel protection.", Target: rule.NewTarget("worker", "worker1")}, | ||
| }}, | ||
| ), | ||
| Entry("should pass when shoot worker enables kernel defaults protection in kubelet config", |
There was a problem hiding this comment.
Suggested change
| Entry("should pass when shoot worker enables kernel defaults protection in kubelet config", | |
| Entry("should fail when shoot worker disables kernel defaults protection in kubelet config", |
| @@ -0,0 +1,17 @@ | |||
| // SPDX-FileCopyrightText: 2023 SAP SE or an SAP affiliate company and Gardener contributors | |||
There was a problem hiding this comment.
Suggested change
| // SPDX-FileCopyrightText: 2023 SAP SE or an SAP affiliate company and Gardener contributors | |
| // SPDX-FileCopyrightText: 2024 SAP SE or an SAP affiliate company and Gardener contributors |
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: