Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve ETCD peer options rules #3

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Improve ETCD peer options rules #3

merged 2 commits into from
Sep 5, 2023

Conversation

AleksandarSavchev
Copy link
Member

What this PR does / why we need it:
This PR improves ETCD peer options rules 242380, 242426, 242432 and 242433 by skipping them when ETCD runs as a single instance, since they are not used in that case.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

`ETCD` peer options rules `242380`, `242426`, `242432` and `242433` are now skipped when `ETCD` runs as a single instance.

@gardener-robot gardener-robot added needs/review Needs review size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) labels Aug 24, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 24, 2023
dimityrmirchev
dimityrmirchev requested changes Aug 26, 2023
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments, other looks good

pkg/provider/gardener/ruleset/disak8sstig/v1r8/242432_test.go Outdated
singleETCDCluster = `
initial-cluster: etcd-main-0=foo
peer-transport-security:
client-cert-auth: false`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
client-cert-auth: false`
cert-file: false`

Shouldn't we use cert-file here for consistency reasons?

pkg/provider/gardener/ruleset/disak8sstig/v1r8/242433_test.go Outdated
singleETCDCluster = `
initial-cluster: etcd-main-0=foo
peer-transport-security:
client-cert-auth: false`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as my other comment

@gardener-robot gardener-robot added the needs/changes Needs (more) changes label Aug 26, 2023
@AleksandarSavchev AleksandarSavchev requested a review from a team as a code owner September 4, 2023 08:08
@gardener-robot-ci-3 gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 4, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 4, 2023
dimityrmirchev
dimityrmirchev approved these changes Sep 5, 2023
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/changes Needs (more) changes needs/review Needs review labels Sep 5, 2023
@dimityrmirchev dimityrmirchev merged commit 7472977 into main Sep 5, 2023
@dimityrmirchev dimityrmirchev deleted the improve-peer-rules branch September 5, 2023 06:21
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 5, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimityrmirchev dimityrmirchev dimityrmirchev approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/m Size of pull request is medium (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@AleksandarSavchev @dimityrmirchev @gardener-robot-ci-1 @gardener-robot-ci-3 @gardener-robot