-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DISA K8s STIG] Add support for version v2r1 #287
Merged
dimityrmirchev
merged 12 commits into
gardener:main
from
AleksandarSavchev:implement-disa-v2.1
Aug 26, 2024
Merged
[DISA K8s STIG] Add support for version v2r1 #287
dimityrmirchev
merged 12 commits into
gardener:main
from
AleksandarSavchev:implement-disa-v2.1
Aug 26, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimityrmirchev
approved these changes
Aug 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
needs/ok-to-test
Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
reviewed/lgtm
Has approval for merging
reviewed/ok-to-test
Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD)
size/xl
Size of pull request is huge (see gardener-robot robot/bots/size.py)
status/closed
Issue is closed (either delivered or triaged)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR adds support for the latest version of DISA K8s STIG
v2r1
. To avoid duplication of rule implementations, the rules that have not been changed between versions are now shared per provider and moved to thepkg/provider/*/ruleset/disak8sstig/rules
dir.Version
v2r1
is a special case where there are no new rules or rule changes betweenv2r1
and the previous versionv1r11
. As such thepkg/provider/*/ruleset/disak8sstig/v1r11
directories are completely removed. For future DISA K8s STIG releases the rule implementations of the latest version will be kept in thepkg/provider/*/ruleset/disak8sstig/rules
dir, and there will be specific directories for previous versions with rule differences.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: