Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DISA K8s STIG] Add support for version v2r1 #287

Merged
merged 12 commits into from
Aug 26, 2024

Conversation

AleksandarSavchev
Copy link
Member

What this PR does / why we need it:
This PR adds support for the latest version of DISA K8s STIG v2r1. To avoid duplication of rule implementations, the rules that have not been changed between versions are now shared per provider and moved to the pkg/provider/*/ruleset/disak8sstig/rules dir.
Version v2r1 is a special case where there are no new rules or rule changes between v2r1 and the previous version v1r11. As such the pkg/provider/*/ruleset/disak8sstig/v1r11 directories are completely removed. For future DISA K8s STIG releases the rule implementations of the latest version will be kept in the pkg/provider/*/ruleset/disak8sstig/rules dir, and there will be specific directories for previous versions with rule differences.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Diki now supports DISA Kubernetes STIG version `v2r1`

@AleksandarSavchev AleksandarSavchev requested a review from a team as a code owner August 21, 2024 08:48
@gardener-robot gardener-robot added the needs/review Needs review label Aug 21, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 21, 2024
@gardener-robot gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) needs/second-opinion Needs second review by someone else labels Aug 21, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 21, 2024
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 26, 2024
@gardener-robot-ci-2 gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 26, 2024
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@dimityrmirchev dimityrmirchev merged commit 1723836 into gardener:main Aug 26, 2024
8 checks passed
@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging status/closed Issue is closed (either delivered or triaged) and removed needs/review Needs review needs/second-opinion Needs second review by someone else labels Aug 26, 2024
@gardener-robot-ci-1 gardener-robot-ci-1 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants