Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ssh rules #2

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Fix ssh rules #2

merged 1 commit into from
Sep 12, 2023

Conversation

AleksandarSavchev
Copy link
Member

What this PR does / why we need it:
This PR fixes rules 242393 and 242394.

Rule 242393 when passed always reported with SSH daemon inactive (or could not be probed), now it should report with SSH daemon service not installed when the systemctl is-active sshd command outputs inactive.

Rule 242394 returned errored status in cases it should have passed. Rule 242394 now correctly passes.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

A bug causing rule `242393` to pass with wrong message was fixed.

A bug causing rule `242394` to error when it should pass was fixed.

@gardener-robot gardener-robot added needs/review Needs review size/s Size of pull request is small (see gardener-robot robot/bots/size.py) labels Aug 24, 2023
@gardener-robot-ci-3 gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Aug 24, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 24, 2023
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Aug 24, 2023
@gardener-robot
Copy link
Contributor

@dimityrmirchev You have pull request review open invite, please check

@AleksandarSavchev AleksandarSavchev requested a review from a team as a code owner September 5, 2023 10:44
@gardener-robot-ci-1 gardener-robot-ci-1 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Sep 5, 2023
@gardener-robot
Copy link
Contributor

@dimityrmirchev You have pull request review open invite, please check

dimityrmirchev
dimityrmirchev approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@dimityrmirchev dimityrmirchev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-robot gardener-robot added reviewed/lgtm Has approval for merging and removed needs/review Needs review labels Sep 12, 2023
@dimityrmirchev dimityrmirchev merged commit 69a3284 into main Sep 12, 2023
@gardener-robot gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Sep 12, 2023
@gardener-robot-ci-2 gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Sep 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimityrmirchev dimityrmirchev dimityrmirchev approved these changes

Assignees
No one assigned
Labels
needs/ok-to-test Needs approval for testing (check PR in detail before setting this label because PR is run on CI/CD) reviewed/lgtm Has approval for merging reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) size/s Size of pull request is small (see gardener-robot robot/bots/size.py) status/closed Issue is closed (either delivered or triaged)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@AleksandarSavchev @gardener-robot @dimityrmirchev @gardener-robot-ci-1 @gardener-robot-ci-2 @gardener-robot-ci-3