Allow user packages in 'make doc' #5950
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fingolfin
approved these changes
Mar 10, 2025
There was a problem hiding this comment.
Seems fine to me, but it would be good if e.g. @ThomasBreuer and @frankluebeck also had a quick look / think about this.
fingolfin
added
topic: documentation
|
I had added the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make docfails if there is no installation of GAPDoc ingap/pkg/because it runs with the-rflag that disables user package directories.This PR removes the
-rflag so that user-installed GAPDoc and other packages can be used in compiling the doc.This is the last link required for users to be able to do a complete install using only PackageManager and no other packages.
(I have some déjà vu with this – apologies if we've talked about this before and I've forgotten.)