WIP: gap root path unification #5941
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace one IS_PLIST check by a direct tnum comparison, split 2 and 3 argument variant implementation
Most arguments are handled in the first stage. In particular all that are relevant for the GC. The second stage is only for the arguments which add GAP roots paths: those involve storing strings, which can be of arbitrary size. We'd like to switch their handling from C strings to GAP strings, but that requires the memory manager to be initialized. With this patch, it *is* initialized before we parse the root paths.
fingolfin
commented
Feb 18, 2025
fingolfin
commented
Feb 18, 2025
fingolfin
commented
Feb 18, 2025
| fi; | ||
| od; | ||
| # Append the new root paths. | ||
| GAPInfo.RootPaths:= Immutable( Concatenation( GAPInfo.RootPaths, |
There was a problem hiding this comment.
I've replaced this now with a loop that uses Add to add each path separately. Various reasons
- the "skip paths already in the list" is more powerful if we do it after ensuring the trailing slash is there
- for HPC-GAP compatibility we may have to switch
GAPInfo.RootPathsfrom a plist to an atomic list, whereAddis supported but notAppend
Anyway this is of course also a natural place to turn relative paths in absolute ones, call realpath, etc. -- but that goes beyond the scope of this PR
fingolfin
commented
Feb 19, 2025
| */ | ||
| Char * SyFindGapRootFile(const Char * filename, Char * buf, size_t size) | ||
| Obj SyFindGapRootFile(const Char * filename) |
There was a problem hiding this comment.
Unfortunately changing SyFindGapRootFile to return a string object currently clashes with work space restoring as it is called during that when restoring loaded compiled modules (including kernel extensions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not yet quite done, but the goal is to ensure that the GAP kernel and library use the same (identical, egal) plist of root paths.
This has multiple benefits:
TODO:
~into$HOMENote that most likely right workspaces are simply broken, but if so I know why and this will be addressed by the above.
Resolves #4675