Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planemo test doesn't work in image #61

Closed
jmchilton opened this issue May 13, 2016 · 8 comments
Closed

planemo test doesn't work in image #61

jmchilton opened this issue May 13, 2016 · 8 comments

Comments

@jmchilton
Copy link
Member

xref #60

Docker Hub has some very fresh images with planemo 0.25.1 that have this same issue - the problem is that planemo uses Galaxy's config/job_conf.xml which has handlers defined that differ in name from the one used by the test framework.

@jmchilton jmchilton added this to the GCC 2016 - Training Day milestone May 13, 2016
@bgruening
Copy link
Member

Urgs. But why is the build-in Galaxy working. This is also using this job_conf.xml isn't it?

@jmchilton
Copy link
Member Author

Yeah - it uses that file - but it has the right handler names. Planemo is using randomly assigned names like planemo28450 for its app name I think. The fix is probably just not to fallback to Galaxy's config - I'll try to get this into planemo 0.26.0.

@bgruening
Copy link
Member

Awesome thanks!

@bgruening
Copy link
Member

Is there a quick fix? I suppose planemo 0.26 is not planned this week :)

@bgruening
Copy link
Member

@jmchilton do you have any time schedule for this. @bebatut is working on new training material and I would like to include a link to a recent working image.

Thanks.

@jmchilton
Copy link
Member Author

I'll release planemo 0.26 with a fix tonight. A quick work around is just not specifying galaxy_root in ~/.planemo.yml.

@bgruening
Copy link
Member

Thanks @jmchilton!

jmchilton added a commit to jmchilton/planemo that referenced this issue May 20, 2016
 - Tell Galaxy that the webapp's server_name is ``main`` regardless - so that handler's can have fixed ``job_conf.xml`` files.
 - Provide a ``job_conf.xml`` if it isn't specified some other way. This prevents ``galaxy_root`` configuration (this should fix galaxyproject/planemo-machine#61).
 - Add Docker options to Galaxy target commands so job_conf.xml can be configured with Docker options appropriately - enable docker for Galaxy tools with ``--docker``.
@jmchilton
Copy link
Member Author

There were a few problems with the fix last night that preventing me from merging before sleep but it has been resolved I think - I will work on a release today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants