Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added GALAXY_MEMORY_MB_PER_SLOT variable #5625

Merged
merged 24 commits into from
Mar 20, 2018

Conversation

bernt-matthias
Copy link
Contributor

When starting to use GALAXY_MEMORY_MB I realized that some tools want to know the total memory and some the memory per thread. I found it cumbersome if tool developers need to calculate that value in the tool script.

So here is my suggestion.

The two if statements may simplify the integration of statements for further cluster schedulers. Some seem to report total memory (apparently SLURM) and others per thread (UNIVA: #4857).

@jmchilton
Copy link
Member

Ping @natefoo - any thoughts? Seems like an okay change to me.

@natefoo
Copy link
Member

natefoo commented Mar 5, 2018

Yeah, seems reasonable. Just a minor request, can it be $GALAXY_MEMORY_MB_PER_SLOT instead?

@bernt-matthias
Copy link
Contributor Author

renamed it.

@bernt-matthias bernt-matthias changed the title added GALAXY_MEMORY_MB_PERSLOT variable added GALAXY_MEMORY_MB_PER_SLOT variable Mar 6, 2018
@bernt-matthias
Copy link
Contributor Author

Where could I add a bit of documentation for this?

@mvdbeek
Copy link
Member

mvdbeek commented Mar 6, 2018

``\$GALAXY_MEMORY_MB`` | Amount of memory in megabytes (1024^2 bytes) allocated by the administrator (via the resource manager) to the tool for the given job. If unset, tools should not attempt to limit memory usage.
seems like a good place

@bernt-matthias
Copy link
Contributor Author

bernt-matthias added a commit to bernt-matthias/tools-iuc that referenced this pull request Mar 12, 2018
@natefoo
Copy link
Member

natefoo commented Mar 12, 2018

Both those places seem like good candidates. The Hub page should probably move to docs.galaxyproject.org though.

@bernt-matthias
Copy link
Contributor Author

@natefoo Is the docs docs.galaxyproject.org content also on github?

@nsoranzo
Copy link
Member

It's generated from files in doc/source/ subdirectory of this repository.

@jmchilton jmchilton merged commit 5f23f5d into galaxyproject:dev Mar 20, 2018
@jmchilton
Copy link
Member

Thanks again - this good stuff and updating documentation is such a great idea (I should try that for something I do someday - meh probably not).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants