Import pyparsing in testing so twill's older version doesn't get loaded. #2656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jmchilton |
There are unintended consequences if not, such as svgwrite not loading properly.
jmchilton
force-pushed
the
pyparsing_testing
branch
from
7a37345 to
93ba35f
Compare
|
What about using a fork of the unmaintained twill instead? Branch 2.0 of @Cito's fork seems pretty good and does not ship an embedded pyparsing any more. This will also give us Python3 support. |
|
@nsoranzo I am +1 on using that fork but that will not make it to 16.07 so I will merge this once tests pass. Would you like to create an issue for swapping? |
|
@martenson Why is that needed for 16.07? |
|
@nsoranzo I do not think it is needed, but given we have a working fix (this PR) and that the fix you mentioned would supersede this I am just saying that we don't have time to wait for it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are unintended consequences if not, such as svgwrite not loading properly.