fix: Add XYK pool existence check before conversion (#1027) #1028
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added a check to verify if the XYK pool exists before performing conversion calculations in
calculate_in_given_out
. This prevents arithmetic errors and improves error handling with descriptive messages.Related Issue
Fixes: #1027
Motivation and Context
This change ensures transactions do not fail due to missing XYK liquidity pools. Instead of encountering an arithmetic error, users will receive a clear DispatchError message indicating that the pool does not exist.
##How Has This Been Tested?
cargo build
cargo test --all
ArithmeticError::Overflow
.Checklist: