chore: fix line endings, white space, typos #622
Closed
+25
−271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hm. This PR points out that Update: I wonder if it's something with MSP since |
|
@korikuzma I'm closing this for now -- #621 covers everything I noticed here except for a typo ("grater" -> "greater"). Can reopen to fix the typo later. |
jsstevenson
added a commit
that referenced
this pull request
Jan 2, 2025
I noticed in #622 that the latest commit on this branch seemed to be in violation of some precommit hooks, so small changes to the schema source were introducing downstream changes to a bunch of unrelated def/json files. This PR * catches up on those changes and * adds a precommit check to github actions to help contributors remember to run appropriate make commands/formatting hooks in their editors (or to install precommit themselves).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also includes a bunch of additional changes being made by precommit (see #621)