forked from bnb-chain/bsc
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core/state: replace writing TrieJournal to the database with a journal file #11
Closed
jingjunLi
wants to merge
40
commits into
fynnss:integrate_snapshot_database_to_pathdb
from
jingjunLi:integrate_snapshot_database_to_pathdb_journal
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
draft release v1.4.2-alpha
33ad452
to
9392ea0
Compare
77c2c7f
to
d33cc0b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When the traffic is high, and BSC shuts down, the PBSS's TrieJournal becomes a large key-value pair (over 2GB), which can cause bugs in Pebble. To address this issue, we use a journal log file to store the TrieJournal instead of persisting it to the database.
Rationale
Changes:
Data Format
Journal Version
Disk Root
Disk Layer
--
**Layer Length**
-- Root
-- State ID
-- Buffer Nodes
--
**Layer Checksum**
Diff Layer
--
**Layer Length**
-- Root
-- Block
-- Trie Nodes
-- Journal Accounts
--
**Layer Checksum**
Journal Path: geth/chaindata/ancient/state.journal
Checksum: SHA256
Example
add an example CLI or API response...
Changes
Notable changes: