Move dns challenge as an additional binary for foxbox (Closes #423, #… #440
Conversation
|
Changes Unknown when pulling 664d68b on julienw:423-424-build-dnschallenge-from-foxbox into * on fxbox:master*. |
julienw
force-pushed
the
423-424-build-dnschallenge-from-foxbox
branch
from
664d68b to
34346d4
Compare
|
@fabricedesre @JohanLorenzo @samgiles what do you think ? |
|
It works for me! |
| @@ -143,17 +143,20 @@ There are several command line options to start the daemon: | |||
| Currently you would likely want to start the daemon like this: | |||
|
|
|||
| ```bash | |||
| cargo run -- -r http://knilxof.org:4242 --disable-tls | |||
| ./run.sh -- -r http://knilxof.org:4242 --disable-tls | |||
There was a problem hiding this comment.
We should not need the extra --
There was a problem hiding this comment.
I discussed with @JohanLorenzo and we decided to keep it especially to be able to use cargo's --verbose.
We could special-case this but this is more work.
There was a problem hiding this comment.
We discussed that with @julienw, we thought -- still has some value, when you want to --verbose or --freatures on cargo, for instance.
There was a problem hiding this comment.
But then your run.sh script adds very little over the cargo command...
There was a problem hiding this comment.
yes, it's merely an alias to make things easier for the developer now that we have several binaries.
Totally open to rework this though :)
|
I'm fine with the approach, but there are a few things to address. |
|
Looks good to me |
|
I pushed the small typo change. |
julienw
force-pushed
the
423-424-build-dnschallenge-from-foxbox
branch
from
0d1ed07 to
6825f2e
Compare
|
landed in ecc92fa |
…424)