-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build and deploy Azure web jobs #613
Conversation
/// | ||
/// - `setParams` - Function used to overwrite webjobs outputpath. | ||
/// - `webSites` - The websites and webjobs to build zips from. | ||
let BuildZip setParams webSites = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should call this package rather than build?
Other problems could be in the package section it doesn't package folders :\ |
/// | ||
/// - `setParams` - Function used to overwrite webjobs outputpath. | ||
/// - `webSites` - The websites and webjobs to deploy. | ||
let DeployWebJobs setParams webSites = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I take in a list of web sites or just one and let the users handle multiple? All this would mean is less code as deployWebJobsToWebSite
would be the deploy method.
I'd really like it to be able to deploy from any location, as my binaries are not in the bin/release folder (currently). |
So an option in the params to specify the zip/dll location would be better? Perhaps default it to bin/release? |
Yes, the source aswell as the target location of the zipping process. I wouldn't mind any defaults, as long as it's not that hard to change the defaults. |
Now packages all files/folders as well
Right, made the change to specify the directory to zip. Doesn't feel right being part of the params type ,might be better with the webjob type so that each job could potentially have a different directory location to zip. |
Could make each WebJob type specify the directory to zip and the location of the zip file. This would give us the most flexible solution I think. |
…ectory/package location. This means we can get rid oft he set params from package/deploy. Removed the uri type extension as it's not used any more.
I've made a change so that each webjob is responsible for it's own dll location/package location. This means there is a bit more emphasis on the end user to specify locations but this does give more flexibility. This is what the code would look like to call it now:
|
That would make it usable for my (and others) usecase(s), I like it. |
Is it ready to merge? |
If every one is happy then yeah |
cool thanks! |
Could you add documentation for this as well, and submit a link to https://github.com/fsharp/fsfoundation/edit/gh-pages/guides/cloud/index.md? |
Something along the lines of: http://fsharp.github.io/FAKE/typescript.html ? |
Yes that would be great |
Deploying webjobs via msdeploy is awkward for my self so I built this bit of code to build a zip of the files in the release folder and and push it via the rest api that Azure Websites have.
This makes use of the zip controller.
It works but is a bit rough in some places, for example it dependent on "/bin/release" for the location of the dlls to zip up.
This is an example of how you'd call it: