Fix ReleaseNotes SemVer #2686
Merged
Fix ReleaseNotes SemVer #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yazeedobaid
reviewed
Jul 21, 2022
| let nugetRegexLegacy = String.getRegEx @"([0-9]+.)+[0-9]+(-[a-zA-Z]+\d*)?(.[0-9]+)?" | ||
| let nugetRegex = | ||
| /// From Fake.Core.SemVer | ||
| let pattern = |
There was a problem hiding this comment.
Can u please re-use patterns from Fake.Core.SemVer instead of duplicating them here?
There was a problem hiding this comment.
Can i pull pattern out of (|SemVer|_|) to use it? Like such?
let pattern =
@"^(?<major>\d+)" +
@"(\.(?<minor>\d+))?" +
@"(\.(?<patch>\d+))?" +
@"(\-(?<pre>[0-9A-Za-z\-\.]+))?" +
@"(\+(?<build>[0-9A-Za-z\-\.]+))?$"
let (|SemVer|_|) version =
match version with
| ParseRegex pattern [major; minor; patch; pre; build] ->
Some [major; minor; patch; pre; build]
| _ ->
None
yazeedobaid
reviewed
Jul 21, 2022
|
Done @yazeedobaid 👍 |
|
Thanks a lot. |
|
Done @yazeedobaid 👍 Hope it worked out. |
|
🎉 Thanks @Freymaurer ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@aggieben, @yazeedobaid
Had to make SemVer parsing a bit more complicated, but should still be clearly understandable. I also added comments to explain certain choices.