make sure to add both dependencymanager compileroptions wherever they… #2481
Conversation
|
|
||
| "--langversion:preview" // needed because of a design choice(bug?) in FCS that parses dependency managers regardless of langversion | ||
| :: dummyPaketDependencyManagerOption // needed to handle and swallow the `paket` dependency manager type | ||
| @ [ "--nowarn:3186" ] // needed because the paket dependencymanager build right now throws some kind of pickling warning. |
There was a problem hiding this comment.
are there other places I'm missing to provide this nowarn? the tests are failing because of that warning I'm trying to suppress here.
There was a problem hiding this comment.
To be honest: I guess that --nowarn just doesn't work for this warning, so you probably just found another bug (welcome to my world, going down the rabit hole)
There was a problem hiding this comment.
It worked when I added it to FSAC to sidestep this same exact error, though. So I am confused.
There was a problem hiding this comment.
Good point. In any case, I don't think there are any other options. On the other hand this is probably reproducible and debuggable so I'd suggest setting a breakpoint here and see if FCS outputs the warning.
IIRC we collect the warnings and report them later so I think we can filter manually as well (as an alternative approach).
BTW have you already reported this strange warning?
There was a problem hiding this comment.
I was going to try to make an independent repro to give to the team, something self contained.
There was a problem hiding this comment.
I already created the issue in dotnet/fsharp#8678 in order to link in the commit messages. Feel free to add the sample there.
It looks like --nowarn is not evaluated in FCS (which I guess makes sense as you easily can filter the returned list yourself). So I changed to this: 9f01307
Fixes the last set of issues I found while integrating into FSAC by making sure the options returned from FAKE for a fake script are more similar to the ones used to compile the script by FAKE.