Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FCS to circumvent MethodNotFound Exception #2475

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

baronfel
Copy link
Contributor

Description

Versions of FCS greater than 34.0.1 introduced overloads of FSharpChecker.Create that have new optional arguments. This means that the usage of FSharpChecker.Create in the Yaaf Scripting file not longer target the same method and so the underlying FCS reference needed to be updated.

This PR performed this update.

TODO

  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)

@matthid
Copy link
Member

matthid commented Feb 27, 2020

Thanks! By the way: Does this already include the #r nuget feature?

@baronfel
Copy link
Contributor Author

It includes the base infrastructure, but we don't currently distribute the built-in Nuget provider that actually handles the nuget resolution. There are still open questions about how that distribution would be handled, IMO.

There's enough here to build and use with a Paket-plugin, for example.

@matthid matthid merged commit 41d9f44 into fsprojects:release/next Mar 5, 2020
@matthid matthid mentioned this pull request Mar 5, 2020
3 tasks
@matthid
Copy link
Member

matthid commented Mar 5, 2020

Ok, we can handle that feature later. I'll try to get out at least an alpha package so we can fix ionide.

@matthid
Copy link
Member

matthid commented Mar 5, 2020

@baronfel You can use 5.19.2-alpha.1526 in a couple of minutes. Let me know if it works (I think it is fine to use the alpha in ionide as it has the same quality bar as a regular release)

When it works I'll probably release 5.20 tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FAKE Support] Broken after latest FCS Update
2 participants