-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass instance of Diagnostics.Process for addOnStarted #2451
Pass instance of Diagnostics.Process for addOnStarted #2451
Conversation
… used in addOnStarted
Ok, but question is if we should add a new method instead as the current change is technically breaking all the following usages: cp |> addOnStarted (fun () -> ()) And it is binary breaking (which probably kind of matters for the Process module as it is used everywhere) |
@matthid You are right. My proposition for new method is |
Yes or 'addOnStartedEx' with a record which we can extend in the future? In any case thanks and congratulations to your first PR :) |
…which can be extended in the future * rollback changes for addOnStarted
@matthid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, lets see if my changes on the web actually compile.
Thanks a lot! |
Description
Pass instance of Diagnostics.Process for created process for function used in addOnStarted
This feature was approved in gitter