Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fake.Testing.SonarQube Several improvements like workdir and local tool support #2438

Merged
merged 4 commits into from
Dec 17, 2019

Conversation

vilinski
Copy link
Contributor

Description

Revisit the Fake.Testing.SonarQube

  • add WorkingDirectory parameter
  • add ToolType parameter to support dotnet tool dotnet-sonarscanner
  • fix obsolete process api usage
  • format SonarQube.fs with fantomas 3.1

TODO

Feel free to open the PR and ask for help

  • New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in help/markdown)

  • unit or integration test exists (or short reasoning why it doesn't make sense)

    Note: Consider using the CreateProcess API which can be tested more easily, see https://github.com/fsharp/FAKE/pull/2131/files#diff-4fb4a77e110fbbe8210205dfe022389b for an example (the changes in the DotNet.Testing.NUnit module)

  • boy scout rule: "leave the code behind in a better state than you found it" (fix warnings, obsolete members or code-style in the places you worked in)

  • (if new module) the module has been linked from the "Modules" menu, edit help/templates/template.cshtml, linking to the API-reference is fine.

  • (if new module) the module is in the correct namespace

  • (if new module) the module is added to Fake.sln (dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)

  • Fake 5 API guideline is honored

Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

@matthid matthid merged commit 1aac550 into fsprojects:release/next Dec 17, 2019
@matthid matthid changed the title Sonarscanner Fake.Testing.SonarQube Several improvements like workdir and local tool support Dec 17, 2019
@matthid matthid mentioned this pull request Dec 17, 2019
@vilinski vilinski deleted the sonarscanner branch December 18, 2019 06:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants