Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use official nuget packages for getLastNuGetVersion #2294

Merged
merged 7 commits into from
Apr 28, 2019

Conversation

matthid
Copy link
Member

@matthid matthid commented Apr 17, 2019

No description provided.

@@ -176,6 +176,11 @@ group netcore
nuget Octokit
nuget Newtonsoft.Json
nuget Paket.Core // prerelease
nuget NuGet.Protocol < 5 // support net462
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe change this to nuget NuGet.Protocol ~> 4 strategy: min? You could omit the others then.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes true, but I don't want min I want latest 4.X - but in this scenario it might be equivalent ;)
Good idea

@matthid
Copy link
Member Author

matthid commented Apr 28, 2019

Let's see how that works out. Thanks @inosik for taking a look.

@matthid matthid merged commit d56056f into release/next Apr 28, 2019
@yazeedobaid yazeedobaid deleted the use_nuget_package branch January 31, 2022 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants