-
Notifications
You must be signed in to change notification settings - Fork 588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ported ILMergeHelper.fs to FAKE 5 as Fake.DotNet.ILMerge #2195
Ported ILMergeHelper.fs to FAKE 5 as Fake.DotNet.ILMerge #2195
Conversation
…n if only for mono
…Net Framework and won't run on Mono
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Honestly, if every PR would look like this maintaining would be much less work ;)
Thanks!
I added just one minor discussion point about the behavior on mono, we can leave it as-is but I feel like users might not realize why stuff is red.
use __ = Trace.traceTask "ILMerge" primaryAssembly | ||
|
||
// The type initializer for 'System.Compiler.CoreSystemTypes' throws on Mono. | ||
// So let task be a no-op marked as failed on non-Windows platforms |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or we throw an exception in order to notify the user
`raise <| NotSupportedException("ILMerge is currently not supported on mono")
…indows platforms, exactly as in the case of FxCop
I guess I'd prefer throwing exception (as you can disable "Targets" via conditional targets already), but I can add that myself if I don't forget. |
Description
Take the old ILMerge task and update it
#load
, so has some operational test validation as wellTODO
I believe these all to be done
help/markdown
)help/templates/template.cshtml
, linking to the API-reference is fine.dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj
)