Develop/fxcop #2174
Develop/fxcop #2174
Conversation
…e code under test
| let serializingObject = Object() | ||
|
|
||
| let testCases = | ||
| if Environment.isWindows then |
There was a problem hiding this comment.
Thanks a lot for the tests! I guess this is because fxcop doesn't run on non-windows platforms at all?
There was a problem hiding this comment.
That was my intention, yes.
|
@kblohm Should we categorize the module somewhere else (Fake.Windows?) |
|
If you expect more analysers, maybe Fake.Analyzers? But i think DotNet is fine. 👍 I personally would not search for something like FxCop under Fake.Windows just because it is not crossplatform. Is it possible to use BlackFox.Vswhere to detect the location? That way it would be consistent with the MsBuild-Module. |
…lity for the purpose, i.e. BlackFox.VsWhere
| <ProjectReference Include="..\Fake.IO.FileSystem\Fake.IO.FileSystem.fsproj" /> | ||
| </ItemGroup> | ||
| <ItemGroup> | ||
| <PackageReference Include="blackfox.vswhere" Version="0.3.2" /> |
There was a problem hiding this comment.
This should go to paket.references
| @@ -0,0 +1,212 @@ | |||
| [<RequireQualifiedAccess>] | |||
| module Fake.DotNet.FxCop | |||
There was a problem hiding this comment.
(optional) I often get the feedback that actual samples help a lot so adding one to the docs here would be nice. Just a simple example like the following is enough:
src/app/Fake.DotNet.FxCop/FxCop.fs
Outdated
|
|
||
| /// This checks the result file with some XML queries for errors | ||
| /// [omit] | ||
| let checkForErrors resultFile = |
There was a problem hiding this comment.
I guess this is public by design?
There was a problem hiding this comment.
If yes, why omit it from the docs?
There was a problem hiding this comment.
That one is just copied verbatim from the legacy implementation, so the design question should really be addressed to the original author.
The function would extract results from FxCop output derived from other sources, so is useful to that extent, but I'm not invested one way or the other.
…ith [omit] in the legacy code), as it's easier to add than remove API
| Expect.isTrue (p.IncludeSummaryReport) | ||
| "A field should have non-default value for a bool" | ||
| Expect.equal args [ "/c" | ||
| "/f:\"" + dummy + "\"" |
There was a problem hiding this comment.
by the way, have you actually run the code? I feel like this quote might be quoted again later and therefore not work as expected.
|
This started out as something to |
|
Thanks for helping out with this! |
Description
Ported FXCopHelper.fs to FAKE 5 as Fake.Tools.FxCop
TODO
I believe these all to be done, assuming that API-docs are the triple-/ comments I see elsewhere in the code base --
help/markdown)help/templates/template.cshtml, linking to the API-reference is fine.dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj)