Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancements to Fake.Core.Xml #2010

Merged
merged 9 commits into from
Jul 2, 2018
Merged

Conversation

BlythMeister
Copy link
Contributor

No description provided.

@matthid
Copy link
Member

matthid commented Jun 29, 2018

The error is a bit hard to find in the CI:
[00:09:39] C:\projects\fake-6w516\src\app\Fake.Core.Xml\Xml.fs(119,9): error FS0041: No overloads match for method 'Load'. The available overloads are shown below. [C:\projects\fake-6w516\src\app\Fake.Core.Xml\Fake.Core.Xml.fsproj]

I guess you need a type annotation somewhere.

@BlythMeister
Copy link
Contributor Author

Oh yeah, 4 signatures on load.

@BlythMeister
Copy link
Contributor Author

@matthid this one should be good now

@BlythMeister
Copy link
Contributor Author

🎉 it builds 😄

@BlythMeister BlythMeister changed the title Add function to load xml document from path Enhancements to Fake.Core.Xml Jul 2, 2018
@matthid
Copy link
Member

matthid commented Jul 2, 2018

Sad that we missed the [<RequireQualifiedAccess>] on the Fake.Core.Xml module :/

@matthid matthid merged commit fb3c841 into fsprojects:release/next Jul 2, 2018
@BlythMeister
Copy link
Contributor Author

Too late to add it I guess without it being breaking...

@BlythMeister BlythMeister deleted the xmlDoc branch May 11, 2021 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants