Fix #1879: Convert Fake.IO.FileSystem/Shell.fs to "module based" #1882
Conversation
|
The CI is failing but I think it's coming from the code in |
|
@MangelMaxime Correct. I'm working on this problem. Seems like some breaking change after
We have to include the |
|
Oh ok for the Ping me on this PR if you need me to rebase it later or fix something in it. |
|
@MangelMaxime If you want you can rebase/merge and it should be green again :) |
MangelMaxime
force-pushed
the
rework_shell_api
branch
from
bea4b6b to
e7c9a90
Compare
build.fsx
Outdated
| @@ -828,7 +892,11 @@ Target.create "CheckReleaseSecrets" (fun _ -> | |||
| ) | |||
| let executeFPM args = | |||
| printfn "%s %s" "fpm" args | |||
| #if BOOTSTRAP | |||
| Shell.exec("fpm", args=args, dir="bin") | |||
There was a problem hiding this comment.
This still seems to be missing (note that this is actually part of Fake.Core.Process)
There was a problem hiding this comment.
Ah yes, I just replace all Shell.PascalCase to Shell.camelCase this one was too much :)
Let's see if the CI is ok now
|
Ok lets see, thanks! |
@matthid I think we should untrack the
.fakefolder because it's specific to each computer.