Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement MSBuild /nowarn command line option #1840

Merged
merged 3 commits into from
Apr 2, 2018
Merged

Implement MSBuild /nowarn command line option #1840

merged 3 commits into from
Apr 2, 2018

Conversation

dungpa
Copy link
Contributor

@dungpa dungpa commented Mar 31, 2018

This is often used as an escape hatch when it is hard to ensure warnaserror for the whole build.

See the context on MSBuild /nowarn at dotnet/msbuild#1366

@matthid matthid changed the base branch from master to rc_1 April 1, 2018 08:56
@matthid
Copy link
Member

matthid commented Apr 1, 2018

Thanks, can you check about the conflicts in the rc_1 branch? (It is mostly because MsBuild was renamed to MSBuild)

@dungpa
Copy link
Contributor Author

dungpa commented Apr 1, 2018

@matthid Done.

@matthid
Copy link
Member

matthid commented Apr 2, 2018

thanks!

@matthid matthid merged commit 798cfb7 into fsprojects:rc_1 Apr 2, 2018
@matthid matthid mentioned this pull request Apr 2, 2018
Closed
9 tasks
@dungpa dungpa deleted the nowarn branch April 2, 2018 10:07
@matthid matthid mentioned this pull request Apr 7, 2018
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dungpa @matthid