Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#1016-MSTest detail switch #1625

Merged
merged 3 commits into from
Aug 30, 2017
Merged

#1016-MSTest detail switch #1625

merged 3 commits into from
Aug 30, 2017

Conversation

alex-bogomaz
Copy link
Contributor

Hello. Please review this PR.
It adds Details parameter to MSTest - issue #1016.
It also should address #1348 (docs for NUnit3 ToolPath).

Sample usage:

Target "Tests" (fun _ ->
    !! (@"UnitTestProject1.dll") 
      |> MSTest (fun p -> { p with Details = ["computername"; "id"; "duration"]})
)

matthid
matthid approved these changes Aug 3, 2017
View reviewed changes
Copy link
Member

@matthid matthid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks!

src/app/Fake.Core.String/String.fs
items
|> List.iter (fun t -> builder |> (action t text) |> ignore)

builder
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should move those to a new StringBuilder module in FAKE 5?
(Not something I expect you to do as part of this PR, just a general thing I noticed now - always happy to get feedback on my thinking)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, StringBulder-related functions could be moved out of Fake.Core.String into separate module.

Another question here - should Fake.StringHelper be marked as "obsolete" - because code of it duplicates Fake.Core.String?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes good point, thanks

@matthid matthid merged commit 0fb413c into fsprojects:master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthid matthid matthid approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alex-bogomaz @matthid