Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Undo all changes in ProcessHelper made for #1194 #1277

Merged
merged 1 commit into from
Jun 20, 2016

Conversation

alexsorokoletov
Copy link
Contributor

No description provided.

@forki
Copy link
Member

forki commented Jun 20, 2016

I wonder if this is needed for all calls on mono!?

@alexsorokoletov
Copy link
Contributor Author

@forki I'm undoing all changes I made in the process helper.
Fixes in XamarinHelper are not related to these changes and I only wanted to solve mono encoding problem for everyone. Obviously, problem is much more complicated that I (silly) thought.

I'll take time and see where we are still using incorrect process start procedures (I have one place in mind called HockeyAppHelper) and make sure we fix the problem there instead of making silver bullet.

@forki
Copy link
Member

forki commented Jun 20, 2016

ok. let me know when you think I should merge this

@alexsorokoletov
Copy link
Contributor Author

@forki this is a good question you ask. I first thought it is needed but some scenarios do not need this. So instead of going from "everyone needs it" it is better to go from "add to those who needs it"

@alexsorokoletov
Copy link
Contributor Author

@forki Please merge this as soon as practically possible. I broke hundreds builds by this change, let's bring them back online. This request brings everything in the ProcessHelper to version 4.28 which was stable in these terms.

@forki forki merged commit 1a2f43a into fsprojects:master Jun 20, 2016
@forki
Copy link
Member

forki commented Jun 20, 2016

ok. release in progress

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants