Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NugetHelper.fs: GetPackageVersion - returns incorrect package version #1342

Closed
bobahml opened this issue Aug 1, 2016 · 4 comments
Closed

Comments

@bobahml
Copy link

bobahml commented Aug 1, 2016

Description

I have 2 package in the deployments folder:

  • Castle.Core.3.3.3
  • Castle.Core-NLog.3.3.3

"Castle.Core", GetPackageVersion "./packages/" "Castle.Core"
-> returns NLog.3.3.3

NLog.3.3.3' is not a valid version string.

Expected behavior

GetPackageVersion in this case must return 3.3.3.

@forki
Copy link
Member

forki commented Aug 1, 2016

Marked as u

bobahml pushed a commit to bobahml/FAKE that referenced this issue Aug 2, 2016
@revuniversal
Copy link

It looks like this was fixed in 7344d28.

@TeaDrivenDev
Copy link
Contributor

Yep, just tested this again with 4.60.0, and it works as expected.

@TeaDrivenDev
Copy link
Contributor

TeaDrivenDev commented May 3, 2017

@forki Is anything missing for closing this? (My goal is getting it out of the up-for-grabs list.)

@forki forki closed this as completed May 4, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants