Skip to content

Commit

Permalink
fix outstanding issues from #1987 (comment)
Browse files Browse the repository at this point in the history
  • Loading branch information
matthid committed Jul 29, 2018
1 parent ed44712 commit eb72ac6
Show file tree
Hide file tree
Showing 7 changed files with 21 additions and 4 deletions.
3 changes: 2 additions & 1 deletion .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,8 @@ Potentially link to an existing issue this PR fixes. For example:
## TODO

- [] New (API-)documentation for new features exist (Note: API-docs are enough, additional docs are in `help/markdown`)
- [] (if bugfix) unit or integration test exists (or short reasoning why it doesn't make sense)
- [] unit or integration test exists (or short reasoning why it doesn't make sense)
- [] (if new module) the module has been linked from the "Modules" menu, edit `help/templates/template.cshtml`, linking to the API-reference is fine.
- [] (if new module) the module is in the correct namespace
- [] (if new module) the module is added to Fake.sln (`dotnet sln Fake.sln add src/app/Fake.*/Fake.*.fsproj`)
- [] Fake 5 [API guideline](https://fake.build/contributing.html#API-Design) is honored
15 changes: 15 additions & 0 deletions Fake.sln
Original file line number Diff line number Diff line change
Expand Up @@ -162,6 +162,8 @@ Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "Fake.Core.UserInput", "src\
EndProject
Project("{6EC3EE1D-3C4E-46DD-8F32-0CC8E7565705}") = "Fake.DotNet.Testing.VSTest", "src\app\Fake.DotNet.Testing.VSTest\Fake.DotNet.Testing.VSTest.fsproj", "{C4C9D7EE-6A52-42F1-9E04-7C44F0EA8922}"
EndProject
Project("{F2A71F9B-5D33-465A-A702-920D77279786}") = "Fake.Tools.Rsync", "src\app\Fake.Tools.Rsync\Fake.Tools.Rsync.fsproj", "{26367457-80C0-44C9-9020-56F4013C13E1}"
EndProject
Global
GlobalSection(SolutionConfigurationPlatforms) = preSolution
Debug|Any CPU = Debug|Any CPU
Expand Down Expand Up @@ -1000,6 +1002,18 @@ Global
{C4C9D7EE-6A52-42F1-9E04-7C44F0EA8922}.Release|x64.Build.0 = Release|Any CPU
{C4C9D7EE-6A52-42F1-9E04-7C44F0EA8922}.Release|x86.ActiveCfg = Release|Any CPU
{C4C9D7EE-6A52-42F1-9E04-7C44F0EA8922}.Release|x86.Build.0 = Release|Any CPU
{26367457-80C0-44C9-9020-56F4013C13E1}.Debug|Any CPU.ActiveCfg = Debug|Any CPU
{26367457-80C0-44C9-9020-56F4013C13E1}.Debug|Any CPU.Build.0 = Debug|Any CPU
{26367457-80C0-44C9-9020-56F4013C13E1}.Debug|x64.ActiveCfg = Debug|Any CPU
{26367457-80C0-44C9-9020-56F4013C13E1}.Debug|x64.Build.0 = Debug|Any CPU
{26367457-80C0-44C9-9020-56F4013C13E1}.Debug|x86.ActiveCfg = Debug|Any CPU
{26367457-80C0-44C9-9020-56F4013C13E1}.Debug|x86.Build.0 = Debug|Any CPU
{26367457-80C0-44C9-9020-56F4013C13E1}.Release|Any CPU.ActiveCfg = Release|Any CPU
{26367457-80C0-44C9-9020-56F4013C13E1}.Release|Any CPU.Build.0 = Release|Any CPU
{26367457-80C0-44C9-9020-56F4013C13E1}.Release|x64.ActiveCfg = Release|Any CPU
{26367457-80C0-44C9-9020-56F4013C13E1}.Release|x64.Build.0 = Release|Any CPU
{26367457-80C0-44C9-9020-56F4013C13E1}.Release|x86.ActiveCfg = Release|Any CPU
{26367457-80C0-44C9-9020-56F4013C13E1}.Release|x86.Build.0 = Release|Any CPU
EndGlobalSection
GlobalSection(SolutionProperties) = preSolution
HideSolutionNode = FALSE
Expand Down Expand Up @@ -1076,6 +1090,7 @@ Global
{648CD0F4-4A99-4EF1-AF56-4FBEA410B57A} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{3B0A5EE3-6696-4EBA-BCF9-8136C7F17040} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{C4C9D7EE-6A52-42F1-9E04-7C44F0EA8922} = {7BFFAE76-DEE9-417A-A79B-6A6644C4553A}
{26367457-80C0-44C9-9020-56F4013C13E1} = {901F162F-8925-4390-89C5-9EE2C343F744}
EndGlobalSection
GlobalSection(ExtensibilityGlobals) = postSolution
SolutionGuid = {058A0C5E-2216-4306-8AFB-0AE28320C26A}
Expand Down
3 changes: 2 additions & 1 deletion help/templates/template.cshtml
Original file line number Diff line number Diff line change
Expand Up @@ -192,10 +192,11 @@
</ul>
</li>
<li>
<a href="/apidocs/v5/index.html#Fake.Tools.Git">Tools</a>
<a href="/apidocs/v5/index.html#Fake.Tools">Tools</a>
<ul>
<li><a href="/apidocs/v5/index.html#Fake.Tools.Git">Git</a></li>
<li><a href="/fake-tools-pickles.html">Pickles</a></li>
<li><a href="/fake-tools-rsync.html">Rsync</a></li>
</ul>
</li>
<li>
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project Sdk="Microsoft.NET.Sdk" ToolsVersion="15.0" xmlns="http://schemas.microsoft.com/developer/msbuild/2003">
<PropertyGroup>
<TargetFrameworks>netstandard1.6;netstandard2.0</TargetFrameworks>
<AssemblyName>Fake.Rsync</AssemblyName>
<TargetFrameworks>net46;netstandard1.6;netstandard2.0</TargetFrameworks>
<AssemblyName>Fake.Tools.Rsync</AssemblyName>
<OutputType>Library</OutputType>
</PropertyGroup>
<ItemGroup>
Expand Down
File renamed without changes.
File renamed without changes.

0 comments on commit eb72ac6

Please sign in to comment.